Skip to content

chore: Update dependabot.yml to use new team label#9135

Merged
NicolasMassart merged 1 commit intomainfrom
fix/dependabot_team_label
Apr 4, 2024
Merged

chore: Update dependabot.yml to use new team label#9135
NicolasMassart merged 1 commit intomainfrom
fix/dependabot_team_label

Conversation

@NicolasMassart
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart commented Apr 4, 2024

Description

Update dependabot.yml to use new team-mobile-platform label

Related issues

Fixes wrong team label in Dependabot PRs

Manual testing steps

  1. Run dependabot
  2. check the correct team-mobile-platform label is assigned to PR

Screenshots/Recordings

NA

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart requested a review from a team as a code owner April 4, 2024 10:37
@NicolasMassart NicolasMassart added the team-mobile-platform Mobile Platform team label Apr 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 4, 2024
@NicolasMassart NicolasMassart self-assigned this Apr 4, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.98%. Comparing base (962c49f) to head (0e0fe25).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9135   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files        1273     1273           
  Lines       31342    31342           
  Branches     3213     3213           
=======================================
  Hits        14414    14414           
  Misses      16079    16079           
  Partials      849      849

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sethkfman
sethkfman approved these changes Apr 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman changed the title Update dependabot.yml to use new team label chore: Update dependabot.yml to use new team label Apr 4, 2024
@NicolasMassart NicolasMassart merged commit 4be64ff into main Apr 4, 2024
@NicolasMassart NicolasMassart deleted the fix/dependabot_team_label branch April 4, 2024 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 4, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NicolasMassart NicolasMassart

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasMassart @codecov-commenter @sethkfman @metamaskbot