Skip to content

test: fix secrets for tenderly#9106

Merged
cortisiko merged 1 commit intomainfrom
e2e/fix-networks-env-path
Apr 1, 2024
Merged

test: fix secrets for tenderly#9106
cortisiko merged 1 commit intomainfrom
e2e/fix-networks-env-path

Conversation

@cortisiko
Copy link
Copy Markdown
Member

@cortisiko cortisiko commented Mar 30, 2024

Description

The RPC URL for the testnet used in swaps was incorrect, and as a result, the tests failed because they could not connect to the network. process.env.TENDERLY_NETWORK_ID was returning undefined. This PR assigns process.env.TENDERLY_NETWORK_ID to a variable before using it in the testnet RPC url. It fixes the issue locally.

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 30, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (3f17ad2) to head (a68ebdc).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9106   +/-   ##
=======================================
  Coverage   45.35%   45.35%           
=======================================
  Files        1272     1272           
  Lines       31247    31247           
  Branches     3189     3189           
=======================================
  Hits        14171    14171           
  Misses      16234    16234           
  Partials      842      842

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cortisiko cortisiko added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 31, 2024
@cortisiko cortisiko marked this pull request as ready for review March 31, 2024 14:17
@cortisiko cortisiko requested a review from a team as a code owner March 31, 2024 14:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a68ebdc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/89f33999-23c1-4cc4-8c94-b4ddd129bae5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added the team-mobile-platform Mobile Platform team label Mar 31, 2024
chrisleewilcox
chrisleewilcox approved these changes Apr 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit ba9a5ba into main Apr 1, 2024
@cortisiko cortisiko deleted the e2e/fix-networks-env-path branch April 1, 2024 23:11
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortisiko @codecov-commenter @chrisleewilcox @metamaskbot