Skip to content

fix: TypeScript lint issue#9068

Merged
gantunesr merged 48 commits intorefactor/encryptorfrom
i-hate-this
Mar 27, 2024
Merged

fix: TypeScript lint issue#9068
gantunesr merged 48 commits intorefactor/encryptorfrom
i-hate-this

Conversation

@owencraston
Copy link
Copy Markdown
Contributor

@owencraston owencraston commented Mar 27, 2024

No description provided.

@owencraston owencraston changed the title I hate this [DO NOT MERGE] Testing Mar 27, 2024
@owencraston owencraston changed the title [DO NOT MERGE] Testing [DO NOT MERGE] Testing Encryptor Mar 27, 2024
@socket-security
Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-controller@9.0.0 None +27 2.29 MB metamaskbot

🚮 Removed packages: npm/@metamask/keyring-controller@8.1.0

View full report↗︎

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/@metamask/eth-keyring-controller@15.1.0

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/eth-keyring-controller@15.1.0

@gantunesr gantunesr changed the base branch from main to refactor/encryptor March 27, 2024 00:31
@sonarqubecloud
Copy link
Copy Markdown

@gantunesr gantunesr changed the title [DO NOT MERGE] Testing Encryptor fix: TypeScript lint issue Mar 27, 2024
@gantunesr gantunesr marked this pull request as ready for review March 27, 2024 01:19
@gantunesr gantunesr requested a review from a team March 27, 2024 01:19
@gantunesr gantunesr requested a review from a team as a code owner March 27, 2024 01:19
@gantunesr gantunesr merged commit d4cf781 into refactor/encryptor Mar 27, 2024
@gantunesr gantunesr deleted the i-hate-this branch March 27, 2024 01:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants