Skip to content

chore: improve yarn setup logs#9025

Merged
jpcloureiro merged 17 commits intomainfrom
contributor-exp/setup-stdout
Apr 10, 2024
Merged

chore: improve yarn setup logs#9025
jpcloureiro merged 17 commits intomainfrom
contributor-exp/setup-stdout

Conversation

@jpcloureiro
Copy link
Copy Markdown
Contributor

@jpcloureiro jpcloureiro commented Mar 21, 2024

Description

Contributor experience improvement

  • Simplify yarn setup logs.
  • Make errors evident by displaying which task failed and what was the problem.
  • Create a foundation to extend the setup script to help turn environment setup into a builtin interactive process.

New Dependencies:

Screenshots/Recordings

Success setup
new-setup-ok

Setup with error
new-setup-fail

CI non-TTY output
image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (543d671) to head (e032a4e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9025      +/-   ##
==========================================
- Coverage   45.55%   45.55%   -0.01%     
==========================================
  Files        1272     1272              
  Lines       31238    31238              
  Branches     3189     3189              
==========================================
- Hits        14232    14231       -1     
- Misses      16167    16168       +1     
  Partials      839      839              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpcloureiro jpcloureiro self-assigned this Mar 21, 2024
@jpcloureiro jpcloureiro added the team-mobile-platform Mobile Platform team label Mar 21, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/execa@8.0.1 environment +9 170 kB ehmicky
npm/listr2@8.0.2 environment +16 499 kB cenk1cenk2
npm/rfdc@1.3.1 None 0 25.2 kB matteo.collina

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 27, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/get-stream@8.0.1
New author npm/rfdc@1.3.1

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/get-stream@8.0.1
  • @SocketSecurity ignore npm/rfdc@1.3.1

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 27, 2024
@jpcloureiro jpcloureiro marked this pull request as ready for review March 27, 2024 11:34
@jpcloureiro jpcloureiro requested a review from a team as a code owner March 27, 2024 11:34
detox utils global install
env variables setup with CI detection
@jpcloureiro jpcloureiro added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 27, 2024
@jpcloureiro jpcloureiro force-pushed the contributor-exp/setup-stdout branch from b5a3db4 to dcdbd24 Compare March 27, 2024 15:16
@jpcloureiro jpcloureiro requested a review from a team as a code owner March 27, 2024 15:16
@jpcloureiro jpcloureiro requested a review from a team March 27, 2024 15:16
@jpcloureiro jpcloureiro force-pushed the contributor-exp/setup-stdout branch from e4a0fb3 to 65fcfb5 Compare March 27, 2024 15:20
@jpcloureiro jpcloureiro changed the title chore: improve yarn setup command logs chore: improve yarn setup logs Mar 27, 2024
@jpcloureiro
Copy link
Copy Markdown
Contributor Author

We shouldn't need to manually jetify our packages anymore

Note that jetifier is included and ran automatically with react-native-community/cli for React Native versions 0.60 and above, so you do not need to install and run jetifier manually.

Source: https://github.com/mikehardy/jetifier

@jpcloureiro
Copy link
Copy Markdown
Contributor Author

Android build fails without jetifier
Screenshot 2024-03-27 at 15 51 16
Screenshot 2024-03-27 at 15 51 24

Bringing jetifier again. It was removed from react-native cli

We should update exodus_react-native-payments and react-native-sensors.

This reverts commit 1348c87.
@jpcloureiro jpcloureiro force-pushed the contributor-exp/setup-stdout branch from 68a93cd to a94ba2a Compare March 27, 2024 15:53
@jpcloureiro jpcloureiro force-pushed the contributor-exp/setup-stdout branch from 7bfc19c to c171c8a Compare March 27, 2024 16:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c171c8a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ff43189c-bc93-4050-99de-c4f402c83276

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9faf042
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e410c97-24f0-470f-8607-c8cce33f68f0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpcloureiro
Copy link
Copy Markdown
Contributor Author

PR smoke e2e test pass: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/254dad9c-e0aa-4d7f-a649-366a0b868d63 on commit c171c8a

Tests started to fail after main merge

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 291b89b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b2a701e-462b-42a7-8497-c88f1d5b8271

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpcloureiro jpcloureiro merged commit ba6c1dc into main Apr 10, 2024
@jpcloureiro jpcloureiro deleted the contributor-exp/setup-stdout branch April 10, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants