Skip to content

chore: Reorder migrations between 7.17.1, 7.18.0, and main#8965

Merged
Cal-L merged 2 commits into
mainfrom
chore/reorder-migrations
Mar 15, 2024
Merged

chore: Reorder migrations between 7.17.1, 7.18.0, and main#8965
Cal-L merged 2 commits into
mainfrom
chore/reorder-migrations

Conversation

@Cal-L

@Cal-L Cal-L commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Description

This PR reorders migrations between 7.17.1, 7.18.0, and main to ensure that it's correct

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner March 15, 2024 21:25
@github-actions

github-actions Bot commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 43.74%. Comparing base (02eef8b) to head (3fa9467).

Files Patch % Lines
app/store/migrations/032.ts 0.00% 11 Missing ⚠️
app/store/migrations/033.ts 81.81% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8965      +/-   ##
==========================================
- Coverage   43.75%   43.74%   -0.01%     
==========================================
  Files        1271     1273       +2     
  Lines       31055    31103      +48     
  Branches     3148     3161      +13     
==========================================
+ Hits        13587    13606      +19     
- Misses      16657    16684      +27     
- Partials      811      813       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Mar 15, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Cal-L Cal-L merged commit 4de7cef into main Mar 15, 2024
@Cal-L Cal-L deleted the chore/reorder-migrations branch March 15, 2024 22:24
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 15, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cal-L @codecov-commenter @tommasini @metamaskbot