Skip to content

fix: unit test metametrics at app startup#8958

Merged
NicolasMassart merged 7 commits intomainfrom
fix/app_unit_test
Apr 3, 2024
Merged

fix: unit test metametrics at app startup#8958
NicolasMassart merged 7 commits intomainfrom
fix/app_unit_test

Conversation

@NicolasMassart
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart commented Mar 15, 2024 •
edited
Loading

Description

  • unit test metametrics at app startup
  • update snapshot
  • update test names to match guidelines

Related issues

Fixes uncovered code

Manual testing steps

NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart
unit test metametrics startup
fa0a4e0 
migrate unit test to RN testing
update snapshot
update test names to match guidelines
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 15, 2024 16:19
@NicolasMassart NicolasMassart self-assigned this Mar 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart added team-mobile-platform Mobile Platform team No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Mar 15, 2024
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fa0a4e0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d1278e6-7e83-4cd0-ae0c-45c738cbe5cb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@NicolasMassart NicolasMassart mentioned this pull request Mar 15, 2024
Merged
12 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: df9950f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd3e435d-54e1-49d1-9549-55bb98070e62

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

MarioAslau
MarioAslau approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Nico!

@NicolasMassart NicolasMassart merged commit 51a14e0 into main Apr 3, 2024
@NicolasMassart NicolasMassart deleted the fix/app_unit_test branch April 3, 2024 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 3, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

@NicolasMassart NicolasMassart

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasMassart @MarioAslau @metamaskbot