fix: prevent repeated incoming transaction notifications#8956
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8956 +/- ##
=======================================
Coverage 43.67% 43.67%
=======================================
Files 1271 1271
Lines 30921 30921
Branches 3092 3092
=======================================
Hits 13506 13506
Misses 16636 16636
Partials 779 779 ☔ View full report in Codecov by Sentry. |
Contributor
|
QA build, Samsung s24+: notification for incoming transaction shown only once. |
vinistevam
approved these changes
Mar 15, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Update the
TransactionControllerpatch to not update the last fetched block number if the new value is lower than the previous one.This in turn prevents excess
incomingTransactionBlockevents being emitted which stops the duplicate notifications.Related issues
Fixes: #8948
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist