Skip to content

fix: Fix unit test, audit, remove redundant track event file#8946

Merged
Cal-L merged 3 commits into
release/7.18.0from
fix/clear-jest-cache
Mar 14, 2024
Merged

fix: Fix unit test, audit, remove redundant track event file#8946
Cal-L merged 3 commits into
release/7.18.0from
fix/clear-jest-cache

Conversation

@Cal-L

@Cal-L Cal-L commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR does a few things:

  • Remove redundant track event directory from Segment intergration
  • Disable jest caching
  • Fix audit issue for follow-redirects. Just regenerating yarn lock to capture higher version

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner March 14, 2024 21:31
@github-actions

github-actions Bot commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Mar 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.18.0@f907234). Click here to learn what that means.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.18.0    #8946   +/-   ##
=================================================
  Coverage                  ?   41.60%           
=================================================
  Files                     ?     1268           
  Lines                     ?    30861           
  Branches                  ?     3084           
=================================================
  Hits                      ?    12840           
  Misses                    ?    17246           
  Partials                  ?      775

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L

Cal-L commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

Will run E2E on release/7.18.0

@Cal-L Cal-L changed the title fix: Fix/clear jest cache fix: Fix unit test, audit, remove redundant track event file Mar 14, 2024
@sonarqubecloud

sonarqubecloud Bot commented Mar 14, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes Mar 14, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 4d0dd4b into release/7.18.0 Mar 14, 2024
@Cal-L Cal-L deleted the fix/clear-jest-cache branch March 14, 2024 22:43
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 19, 2024
@metamaskbot

metamaskbot commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was added to branch 7.18.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cal-L @codecov-commenter @metamaskbot @sethkfman