Skip to content

fix: circular dependency on MetaMetrics configure#8937

Merged
NicolasMassart merged 1 commit into
mainfrom
fix/8888_metametrics_circular_dep
Mar 14, 2024
Merged

fix: circular dependency on MetaMetrics configure#8937
NicolasMassart merged 1 commit into
mainfrom
fix/8888_metametrics_circular_dep

Conversation

@NicolasMassart

@NicolasMassart NicolasMassart commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Move identify call out for metametrics to prevent circular dependency issue.
Call it just after the app index metametrics configuration.

Related issues

Fixes: issue introduced in #8888

Manual testing steps

NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart added the team-mobile-platform Mobile Platform team label Mar 14, 2024
@NicolasMassart NicolasMassart self-assigned this Mar 14, 2024
@github-actions

github-actions Bot commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 43.26%. Comparing base (e63269f) to head (0807147).

Files Patch % Lines
app/components/Nav/App/index.js 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8937      +/-   ##
==========================================
- Coverage   43.26%   43.26%   -0.01%     
==========================================
  Files        1271     1271              
  Lines       30920    30921       +1     
  Branches     3092     3092              
==========================================
  Hits        13379    13379              
  Misses      16769    16769              
- Partials      772      773       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolasMassart
move identify call out for metametrics
0807147 
prevent circular dependency issue
@NicolasMassart NicolasMassart force-pushed the fix/8888_metametrics_circular_dep branch from cc93096 to 0807147 Compare March 14, 2024 15:21
@MetaMask MetaMask deleted a comment from sonarqubecloud Bot Mar 14, 2024
@sonarqubecloud

sonarqubecloud Bot commented Mar 14, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicolasMassart NicolasMassart marked this pull request as ready for review March 14, 2024 15:34
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 14, 2024 15:34
@github-actions

github-actions Bot commented Mar 14, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0807147
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/11d44a7a-142a-4573-8565-31ab2fd6b9b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Mar 14, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@NicolasMassart NicolasMassart merged commit 2c0d6ce into main Mar 14, 2024
@NicolasMassart NicolasMassart deleted the fix/8888_metametrics_circular_dep branch March 14, 2024 16:37
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@NicolasMassart NicolasMassart

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasMassart @codecov-commenter @Cal-L @metamaskbot