Skip to content

feat: Remove powered by blockaid line#8935

Merged
segun merged 3 commits intomainfrom
olu/remove-powered-by
Mar 18, 2024
Merged

feat: Remove powered by blockaid line#8935
segun merged 3 commits intomainfrom
olu/remove-powered-by

Conversation

@segun
Copy link
Copy Markdown
Contributor

@segun segun commented Mar 14, 2024

Description

Removing the "powered by Blockaid" line

Related issues

Fixes: #2228

Manual testing steps

  1. Launch MM
  2. Open testdapp
  3. Click any malicious transaction under PPOM section
  4. See the powered by blockaid line
  5. Checkout this branch
  6. Repeat 1-3
  7. See there's no powered by blockaid line

Screenshots/Recordings

Before

Screenshot 2024-03-14 at 16 26 35

After

Screenshot 2024-03-14 at 15 29 27

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Mar 14, 2024
@segun segun self-assigned this Mar 14, 2024
@segun segun requested a review from a team as a code owner March 14, 2024 13:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (e63269f) to head (a7b77d0).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8935      +/-   ##
==========================================
- Coverage   43.26%   43.26%   -0.01%     
==========================================
  Files        1271     1271              
  Lines       30920    30916       -4     
  Branches     3092     3092              
==========================================
- Hits        13379    13375       -4     
  Misses      16769    16769              
  Partials      772      772

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 19a626a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a9c601d-c5dc-4711-870b-a2cd146adb90

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

blackdevelopa
blackdevelopa reviewed Mar 14, 2024
View reviewed changes
segun added 2 commits March 14, 2024 18:09
@segun
Remove powered by
e425fa2 
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@segun
fix locales.
d4153ed 
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@segun segun force-pushed the olu/remove-powered-by branch from 19a626a to d4153ed Compare March 14, 2024 15:10
@segun
More locale changes.
a7b77d0 
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@segun segun requested a review from blackdevelopa March 14, 2024 15:16
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@segun segun merged commit 0550041 into main Mar 18, 2024
@segun segun deleted the olu/remove-powered-by branch March 18, 2024 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@segun segun

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@segun @codecov-commenter @jpuri @blackdevelopa @metamaskbot