Skip to content

chore: v7.18.0 RC 2 version bump to 1279#8924

Merged
Cal-L merged 1 commit into
release/7.18.0from
RC-build-bump
Mar 14, 2024
Merged

chore: v7.18.0 RC 2 version bump to 1279#8924
Cal-L merged 1 commit into
release/7.18.0from
RC-build-bump

Conversation

@Andepande

@Andepande Andepande commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

cc

Description

  • Bumped app build version from 1273 -> 1279, for RC 2

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Andepande Andepande requested a review from a team as a code owner March 13, 2024 22:01
@sonarqubecloud

sonarqubecloud Bot commented Mar 13, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Mar 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.62%. Comparing base (f6ab1b3) to head (3055bfe).

Additional details and impacted files 
@@                Coverage Diff                 @@
##           release/7.18.0    #8924      +/-   ##
==================================================
- Coverage           43.24%   41.62%   -1.63%     
==================================================
  Files                1271     1269       -2     
  Lines               30913    30866      -47     
  Branches             3090     3084       -6     
==================================================
- Hits                13369    12847     -522     
- Misses              16769    17243     +474     
- Partials              775      776       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cal-L
Cal-L approved these changes Mar 14, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L changed the title Build-version-bump v7.18.0 RC 2 version bump to 1279 Mar 14, 2024
@Cal-L Cal-L changed the title v7.18.0 RC 2 version bump to 1279 build: v7.18.0 RC 2 version bump to 1279 Mar 14, 2024
@Cal-L Cal-L changed the title build: v7.18.0 RC 2 version bump to 1279 chore: v7.18.0 RC 2 version bump to 1279 Mar 14, 2024
@Cal-L Cal-L merged commit cbddd7d into release/7.18.0 Mar 14, 2024
@Cal-L Cal-L deleted the RC-build-bump branch March 14, 2024 02:38
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 19, 2024
@metamaskbot

metamaskbot commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was added to branch 7.18.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.18.0 Issue or pull request that will be included in release 7.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Andepande @codecov-commenter @metamaskbot @Cal-L