Skip to content

chore: Include env variable copying into yarn setup command#8919

Merged
smilingkylan merged 7 commits into
mainfrom
kylan/readme-improvements
Mar 18, 2024
Merged

chore: Include env variable copying into yarn setup command#8919
smilingkylan merged 7 commits into
mainfrom
kylan/readme-improvements

Conversation

@smilingkylan

@smilingkylan smilingkylan commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Description

This task is an update to the on-boarding process, helping streamline the creation of environment variables.

Related issues

Works on: https://github.com/MetaMask/mobile-planning/issues/1465

Manual testing steps

  1. Delete (or change the file name) of .ios.env, .android.env, and .js.env files. Then run yarn setup and see if new files are created with default values.

Screenshots/Recordings

env-variables-screen-capture-edit-1.mp4

Before

Before you had to manually use a cp ... command, now it is included in yarn setup if the files do not already exist

After

Now the yarn setup command generates the .env files. See earlier screen recording.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 13, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6fb862e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b860fc8e-a579-4040-86ed-79696538453c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter

codecov-commenter commented Mar 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (e63269f) to head (bee455f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8919   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files        1271     1271           
  Lines       30920    30920           
  Branches     3092     3092           
=======================================
  Hits        13379    13379           
  Misses      16769    16769           
  Partials      772      772

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilingkylan smilingkylan marked this pull request as ready for review March 14, 2024 15:14
@smilingkylan smilingkylan requested a review from a team as a code owner March 14, 2024 15:14
@github-actions

github-actions Bot commented Mar 14, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bee455f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09d49a53-6344-4892-866b-884213c39af3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@smilingkylan smilingkylan added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2024
jpcloureiro
jpcloureiro previously approved these changes Mar 14, 2024
View reviewed changes

@jpcloureiro jpcloureiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Great addition Kylan 👍

tommasini
tommasini reviewed Mar 14, 2024
View reviewed changes
Comment thread ios/Podfile.lock Outdated
NicolasMassart
NicolasMassart reviewed Mar 14, 2024
View reviewed changes
Comment thread scripts/postinstall.sh
@sonarqubecloud

sonarqubecloud Bot commented Mar 15, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@smilingkylan smilingkylan merged commit f88bc83 into main Mar 18, 2024
@smilingkylan smilingkylan deleted the kylan/readme-improvements branch March 18, 2024 14:07
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 18, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
@smilingkylan smilingkylan restored the kylan/readme-improvements branch March 20, 2024 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gauthierpetetin gauthierpetetin gauthierpetetin left review comments

@tommasini tommasini Awaiting requested review from tommasini

@NicolasMassart NicolasMassart Awaiting requested review from NicolasMassart

+1 more reviewer

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@smilingkylan @codecov-commenter @jpcloureiro @NicolasMassart @gauthierpetetin @tommasini @metamaskbot