Skip to content

feat: add linea sepolia network and deprecate Linea Goerli network#8908

Merged
sethkfman merged 7 commits into
mainfrom
feat/add-linea-sepolia-network
Mar 18, 2024
Merged

feat: add linea sepolia network and deprecate Linea Goerli network#8908
sethkfman merged 7 commits into
mainfrom
feat/add-linea-sepolia-network

Conversation

@VGau

@VGau VGau commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

Description

  • A new Linea Sepolia network will be released soon. This PR adds support for the Linea Sepolia network in the MetaMask mobile app.
  • Deprecate Linea Goerli network

Related issues

Fixes:

Manual testing steps

For Linea Sepolia:

  1. Select Linea Sepolia network
  2. Send a transaction
  3. Check the transaction result in the explorer
  4. Make sure the Linea Sepolia network is display in the network settings page

For Linea Goerli deprecation:

  1. Select Linea Goerli network
  2. Check that Linea Goerli deprecation message is display at the bottom of the screen

Screenshots/Recordings

Before

After

mobile-linea-sepolia.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@VGau VGau added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-linea Linea team labels Mar 12, 2024
@VGau VGau requested a review from a team as a code owner March 12, 2024 15:19
@github-actions

github-actions Bot commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 14, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9bc6cf5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c099b9e4-96e2-498d-8d03-ad2111b620ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@VGau VGau force-pushed the feat/add-linea-sepolia-network branch from e016f62 to d8d80fc Compare March 15, 2024 12:04
@codecov-commenter

codecov-commenter commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 43.68%. Comparing base (1630a58) to head (6001f06).

Files Patch % Lines
app/util/networks/index.js 50.00% 2 Missing ⚠️
...Settings/NetworksSettings/NetworkSettings/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8908   +/-   ##
=======================================
  Coverage   43.67%   43.68%           
=======================================
  Files        1271     1271           
  Lines       30921    30926    +5     
  Branches     3092     3092           
=======================================
+ Hits        13506    13509    +3     
- Misses      16636    16638    +2     
  Partials      779      779

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Mar 15, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: de15611
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b2d0e82-f03b-4769-b5e2-21b938572467

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@VGau VGau added Run Smoke E2E and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E labels Mar 15, 2024
@sonarqubecloud

sonarqubecloud Bot commented Mar 15, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions

github-actions Bot commented Mar 15, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6001f06
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f7bc27f1-47cc-44e1-a803-1b822103cb61

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman reviewed Mar 15, 2024
View reviewed changes
Comment thread app/images/image-icons.js
Comment thread app/util/networks/index.js
sethkfman
sethkfman approved these changes Mar 18, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit aa14537 into main Mar 18, 2024
@sethkfman sethkfman deleted the feat/add-linea-sepolia-network branch March 18, 2024 15:46
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-linea Linea team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VGau @codecov-commenter @sethkfman @metamaskbot