Skip to content

fix: Added migration from 7.17.1 and re order migration on 7.18.0#8903

Merged
Cal-L merged 10 commits into
release/7.18.0from
update/tokens-disappearing-migraitons-fix
Mar 14, 2024
Merged

fix: Added migration from 7.17.1 and re order migration on 7.18.0#8903
Cal-L merged 10 commits into
release/7.18.0from
update/tokens-disappearing-migraitons-fix

Conversation

@tommasini

@tommasini tommasini commented Mar 12, 2024 •
edited by NicolasMassart
Loading

Copy link
Copy Markdown
Contributor

Description
Fix to migration 29 with missing tokens related migrations, migration 30 with PPOM enabled by default, migration 31 to help user impacted by missing migration on 29, migration 32 remove goerli

Also added migration 33, to recover from the crash of the users that the migration 29 and 30 didn't had effect.

Related issues

Fixes #8849

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini
fix to migration 29 with missing tokens related migrations, migration…
402f8a6 
… 30 with PPOM enabled by default, migration 31 to help user impacted by missing migration on 29, migration 32 remove goerli
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Mar 12, 2024
@tommasini tommasini requested a review from a team as a code owner March 12, 2024 12:50
@github-actions

github-actions Bot commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 12, 2024
@codecov-commenter

codecov-commenter commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 58.46154% with 81 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/7.18.0@4d0dd4b). Click here to learn what that means.

Files Patch % Lines
app/store/migrations/031.ts 65.33% 9 Missing and 17 partials ⚠️
app/store/migrations/029.ts 63.23% 8 Missing and 17 partials ⚠️
app/store/migrations/032.ts 0.00% 25 Missing ⚠️
app/store/migrations/033.ts 81.81% 2 Missing and 2 partials ⚠️
app/store/migrations/030.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.18.0    #8903   +/-   ##
=================================================
  Coverage                  ?   41.68%           
=================================================
  Files                     ?     1270           
  Lines                     ?    31041           
  Branches                  ?     3153           
=================================================
  Hits                      ?    12939           
  Misses                    ?    17293           
  Partials                  ?      809

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Mar 12, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 791b0c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a05b7517-d1c5-4f23-8679-b7be2b021e1f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Mar 12, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8c83676
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55408c0b-4c95-4285-a047-566696c40c0f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Mar 12, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6354420
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5d82302-c2db-491c-b731-b23c61e329bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L reviewed Mar 13, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all the e2e smoke are failing + 1 unit test failure

@github-actions

github-actions Bot commented Mar 13, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 461eada
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5fd2e32b-1156-42a4-b27a-258b7d21d586

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman approved these changes Mar 13, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cal-L
Cal-L approved these changes Mar 13, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Mar 14, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b9f18d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6dc183fa-d245-47b1-bf29-3ab9b6b65c78

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 14, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Cal-L Cal-L merged commit dc3fc99 into release/7.18.0 Mar 14, 2024
@Cal-L Cal-L deleted the update/tokens-disappearing-migraitons-fix branch March 14, 2024 22:57
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 19, 2024
@metamaskbot

metamaskbot commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was added to branch 7.18.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tommasini @codecov-commenter @metamaskbot @sethkfman @Cal-L @Andepande