Skip to content

chore: cherry-pick #8859#8874

Merged
NicolasMassart merged 1 commit into
release/7.18.0from
chore/cherry-pick-8859
Mar 7, 2024
Merged

chore: cherry-pick #8859#8874
NicolasMassart merged 1 commit into
release/7.18.0from
chore/cherry-pick-8859

Conversation

@github-actions

@github-actions github-actions Bot commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

This PR cherry-picks #8859

- add env vars mapping in build script
- add calls to qa and release steps
- update flask function
@NicolasMassart NicolasMassart self-assigned this Mar 7, 2024
@NicolasMassart NicolasMassart added team-mobile-platform Mobile Platform team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 7, 2024
@NicolasMassart NicolasMassart marked this pull request as ready for review March 7, 2024 10:27
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 7, 2024 10:27
@github-actions

github-actions Bot commented Mar 7, 2024

Copy link
Copy Markdown
Contributor Author

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 295fccc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4666df36-0c34-4f22-a946-c549e6ca01d1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart merged commit a674fbb into release/7.18.0 Mar 7, 2024
@NicolasMassart NicolasMassart deleted the chore/cherry-pick-8859 branch March 7, 2024 10:55
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 7, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was cherry-picked in branch 7.18.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants