Skip to content

fix: PPOM - Closing alert icon overloads text box#8858

Merged
blackdevelopa merged 1 commit into
mainfrom
8782/close_alert
Mar 8, 2024
Merged

fix: PPOM - Closing alert icon overloads text box#8858
blackdevelopa merged 1 commit into
mainfrom
8782/close_alert

Conversation

@blackdevelopa

@blackdevelopa blackdevelopa commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The close icon overflows outside the text box when triggering a benign request

Related issues

Fixes: #8782

Manual testing steps

  1. Go to MM test dapp
  2. Trigger a benign request
  3. The close icon should be inside the text box

Screenshots/Recordings

Before

Screen.Recording.2024-03-06.at.10.44.14.mov

After

Screen.Recording.2024-03-06.at.10.58.15.mov
Screen.Recording.2024-03-06.at.10.58.50.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 6, 2024 10:11
@github-actions

github-actions Bot commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title fix PPOM - Closing alert icon overloads text box fix: PPOM - Closing alert icon overloads text box Mar 6, 2024
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Mar 6, 2024
@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Mar 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.61%. Comparing base (d669eb3) to head (e323975).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8858      +/-   ##
==========================================
- Coverage   41.61%   41.61%   -0.01%     
==========================================
  Files        1269     1269              
  Lines       30869    30871       +2     
  Branches     3086     3086              
==========================================
  Hits        12846    12846              
- Misses      17246    17248       +2     
  Partials      777      777

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa blackdevelopa merged commit 75e1442 into main Mar 8, 2024
@blackdevelopa blackdevelopa deleted the 8782/close_alert branch March 8, 2024 14:50
@blackdevelopa blackdevelopa self-assigned this Mar 8, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 8, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

+1 more reviewer

@segun segun segun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blackdevelopa blackdevelopa

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Closing alert icon overloads text box

6 participants

@blackdevelopa @codecov-commenter @segun @jpuri @pedronfigueiredo @metamaskbot