Skip to content

fix: network filtered view crash#8846

Merged
tommasini merged 2 commits into
mainfrom
fix/8822-network-filtered-list-crash
Mar 5, 2024
Merged

fix: network filtered view crash#8846
tommasini merged 2 commits into
mainfrom
fix/8822-network-filtered-list-crash

Conversation

@tommasini

@tommasini tommasini commented Mar 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Network list filtered view crash when removing the network on the redux state on the add network view and then it's navigating back to the screen, but the list is not updated

This needs to be fixed to move forward with E2E work

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

https://recordit.co/O3haA4sCxZ

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Mar 5, 2024
@tommasini tommasini requested a review from a team as a code owner March 5, 2024 12:44
@github-actions

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 5, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 17d36c8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d53561b-89cc-4fd6-888f-ecd3b2f4a7ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter

codecov-commenter commented Mar 5, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 41.61%. Comparing base (d669eb3) to head (17d36c8).

Files Patch % Lines
...omponents/Views/Settings/NetworksSettings/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8846      +/-   ##
==========================================
- Coverage   41.61%   41.61%   -0.01%     
==========================================
  Files        1269     1269              
  Lines       30869    30871       +2     
  Branches     3086     3086              
==========================================
  Hits        12846    12846              
- Misses      17246    17248       +2     
  Partials      777      777

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cortisiko
cortisiko approved these changes Mar 5, 2024
View reviewed changes

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

MarioAslau
MarioAslau approved these changes Mar 5, 2024
View reviewed changes

@MarioAslau MarioAslau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tommasini tommasini merged commit 0c45fbf into main Mar 5, 2024
@tommasini tommasini deleted the fix/8822-network-filtered-list-crash branch March 5, 2024 20:40
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 5, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 5, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tommasini @codecov-commenter @cortisiko @MarioAslau @metamaskbot