Skip to content

chore: Remove cross-fetch resolution#8836

Merged
Gudahtt merged 1 commit into
mainfrom
remove-cross-fetch-resolution
Mar 5, 2024
Merged

chore: Remove cross-fetch resolution#8836
Gudahtt merged 1 commit into
mainfrom
remove-cross-fetch-resolution

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Mar 4, 2024

Copy link
Copy Markdown
Member

Description

This resolution was added in #4249 to update the package in preparation for this package being updated in a controller update. That update happened long ago, and this resolution was not required to update the package in the first place. Today this just prevents the package from being updated.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-mobile-platform Mobile Platform team label Mar 4, 2024
@Gudahtt Gudahtt force-pushed the remove-cross-fetch-resolution branch from 14ab5ed to abe3e90 Compare March 4, 2024 21:09
@Gudahtt Gudahtt added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Mar 4, 2024
@Gudahtt Gudahtt marked this pull request as ready for review March 4, 2024 21:10
@Gudahtt Gudahtt requested a review from a team as a code owner March 4, 2024 21:10
@socket-security

socket-security Bot commented Mar 4, 2024 •
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/cross-fetch@3.1.8 network +7 956 kB lquixada

🚮 Removed packages: npm/cross-fetch@2.2.6

View full report↗︎

@github-actions

github-actions Bot commented Mar 4, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: abe3e90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd1d9450-a602-4c0a-a6ff-b8688bf3d964

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter

codecov-commenter commented Mar 4, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.61%. Comparing base (247d3ab) to head (abe3e90).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8836   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files        1269     1269           
  Lines       30869    30869           
  Branches     3086     3086           
=======================================
  Hits        12847    12847           
  Misses      17245    17245           
  Partials      777      777

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt force-pushed the remove-cross-fetch-resolution branch from abe3e90 to 52c6209 Compare March 5, 2024 13:21
@github-actions

github-actions Bot commented Mar 5, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 52c6209
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e31824b-9adf-498c-8617-c91544a5aaa4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Gudahtt
chore: Remove cross-fetch resolution
7cc668f 
This resolution was added in #4249 to update the package in
preparation for this package being updated in a controller update. That
update happened long ago, and this resolution was not required to
update the package in the first place. Today this just prevents the
package from being updated.
@Gudahtt Gudahtt force-pushed the remove-cross-fetch-resolution branch from 52c6209 to 7cc668f Compare March 5, 2024 16:16
@github-actions

github-actions Bot commented Mar 5, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7cc668f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/417f9eeb-56aa-4955-9fda-b6027ba25c74

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Gudahtt

Gudahtt commented Mar 5, 2024

Copy link
Copy Markdown
Member Author

Two E2E failures, but both in different test suites. And neither failure seems related to this package at all (this dependency change only affects the SDK library). It worked the third time though. The failures must have been intermittent failures.

Cal-L
Cal-L approved these changes Mar 5, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit a73e159 into main Mar 5, 2024
@Gudahtt Gudahtt deleted the remove-cross-fetch-resolution branch March 5, 2024 17:13
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 5, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 5, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gudahtt @codecov-commenter @Cal-L @metamaskbot