Skip to content

chore: Remove pac-resolver resolution#8811

Merged
Gudahtt merged 1 commit into
mainfrom
remove-pac-resolver-resolution
Mar 4, 2024
Merged

chore: Remove pac-resolver resolution#8811
Gudahtt merged 1 commit into
mainfrom
remove-pac-resolver-resolution

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Mar 1, 2024

Copy link
Copy Markdown
Member

Description

This resolution was added in #3280 to force this package to update, to resolve a security advisory. However, the package using this package has since been updated, and this resolution is now having the effect of downgrading this package from v7 to v5.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-mobile-platform Mobile Platform team label Mar 1, 2024
@Gudahtt Gudahtt marked this pull request as ready for review March 1, 2024 20:49
@Gudahtt Gudahtt requested a review from a team as a code owner March 1, 2024 20:49
@Gudahtt Gudahtt force-pushed the remove-pac-resolver-resolution branch from b3bdf68 to 92c10a2 Compare March 1, 2024 20:49
@Gudahtt Gudahtt changed the title core: Remove pac-resolver resolution chore: Remove pac-resolver resolution Mar 1, 2024
@github-actions

github-actions Bot commented Mar 1, 2024 •
edited by Gudahtt
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 92c10a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8194ac19-868b-4766-8538-7acda32490e1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter

codecov-commenter commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.60%. Comparing base (c575f53) to head (92c10a2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8811   +/-   ##
=======================================
  Coverage   41.60%   41.60%           
=======================================
  Files        1269     1269           
  Lines       30859    30859           
  Branches     3082     3082           
=======================================
  Hits        12840    12840           
  Misses      17243    17243           
  Partials      776      776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2024
@Gudahtt Gudahtt force-pushed the remove-pac-resolver-resolution branch from 92c10a2 to a68cdfc Compare March 4, 2024 13:21
@socket-security

socket-security Bot commented Mar 4, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/pac-resolver@5.0.1

View full report↗︎

@Gudahtt
core: Remove pac-resolver resolution
b7321a9 
This resolution was added in #3280 to force this package to update, to
resolve a security advisory. However, the package using this package
has since been updated, and this resolution is now having the effect of
_downgrading_ this package from v7 to v5.
@Gudahtt Gudahtt force-pushed the remove-pac-resolver-resolution branch from a68cdfc to b7321a9 Compare March 4, 2024 16:21
Cal-L
Cal-L approved these changes Mar 4, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Gudahtt Gudahtt merged commit 890a149 into main Mar 4, 2024
@Gudahtt Gudahtt deleted the remove-pac-resolver-resolution branch March 4, 2024 16:35
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 4, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gudahtt @codecov-commenter @Cal-L @metamaskbot