Skip to content

chore: Remove minimatch resolution#8807

Merged
Gudahtt merged 1 commit into
mainfrom
remove-minimatch-resolution
Mar 4, 2024
Merged

chore: Remove minimatch resolution#8807
Gudahtt merged 1 commit into
mainfrom
remove-minimatch-resolution

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Mar 1, 2024

Copy link
Copy Markdown
Member

Description

This minimatch resolution was added in #5142 to address a security advisory. It is no longer needed, that advisory is not present after removing the resolution.

This resolution was unsafe because it was forcing the use of incompatible versions of the package.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-mobile-platform Mobile Platform team label Mar 1, 2024
@Gudahtt Gudahtt requested a review from a team as a code owner March 1, 2024 19:41
@codecov-commenter

codecov-commenter commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.61%. Comparing base (7b0956e) to head (95a599c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8807   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files        1269     1269           
  Lines       30869    30869           
  Branches     3086     3086           
=======================================
  Hits        12847    12847           
  Misses      17245    17245           
  Partials      777      777

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt force-pushed the remove-minimatch-resolution branch from 2d00166 to 6c452c5 Compare March 1, 2024 20:18
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2024
@github-actions

github-actions Bot commented Mar 1, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c452c5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31883eb1-ee80-4834-8a40-69a5da22bead

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L previously approved these changes Mar 2, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt force-pushed the remove-minimatch-resolution branch from 6c452c5 to 0f7ab5d Compare March 4, 2024 15:55
@Gudahtt

Gudahtt commented Mar 4, 2024

Copy link
Copy Markdown
Member Author

Rebased to resolve conflicts

Cal-L
Cal-L approved these changes Mar 4, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt
chore: Remove minimatch resolution
95a599c 
This `minimatch` resolution was added in #5142 to address a security
advisory. It is no longer needed, that advisory is not present after
removing the resolution.

This resolution was unsafe because it was forcing the use of
incompatible versions of the package.
@Gudahtt Gudahtt force-pushed the remove-minimatch-resolution branch from 0f7ab5d to 95a599c Compare March 4, 2024 17:49
@Gudahtt

Gudahtt commented Mar 4, 2024

Copy link
Copy Markdown
Member Author

Rebased to resolve conflicts

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Gudahtt Gudahtt merged commit fe5f991 into main Mar 4, 2024
@Gudahtt Gudahtt deleted the remove-minimatch-resolution branch March 4, 2024 18:01
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 4, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gudahtt @codecov-commenter @Cal-L @gauthierpetetin @metamaskbot