Skip to content

chore: Remove glob resolution#8802

Merged
Gudahtt merged 2 commits into
mainfrom
remove-glob-resolution
Mar 4, 2024
Merged

chore: Remove glob resolution#8802
Gudahtt merged 2 commits into
mainfrom
remove-glob-resolution

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Mar 1, 2024

Copy link
Copy Markdown
Member

Description

This glob resolution was added in #5142 to address a security advisory. It is no longer needed, that advisory is not present after removing the resolution.

This resolution was unsafe because it was forcing the use of incompatible versions of the package.

Related issues

N/A

Manual testing steps

Run yarn audit:ci, and see that there are no advisories.

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-mobile-platform Mobile Platform team label Mar 1, 2024
@Gudahtt Gudahtt requested a review from a team as a code owner March 1, 2024 16:46
@socket-security

socket-security Bot commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/foreground-child@3.1.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@codecov-commenter

codecov-commenter commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.60%. Comparing base (178cf04) to head (6a0083f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8802   +/-   ##
=======================================
  Coverage   41.60%   41.60%           
=======================================
  Files        1269     1269           
  Lines       30859    30859           
  Branches     3082     3082           
=======================================
  Hits        12840    12840           
  Misses      17243    17243           
  Partials      776      776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt force-pushed the remove-glob-resolution branch from 2601f3e to d5b105d Compare March 1, 2024 17:25
@Gudahtt

Gudahtt commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@SocketSecurity ignore npm/foreground-child@3.1.1

It makes sense for this package to have shell access, it's a library used by shell scripts to spawn a new process

@Gudahtt Gudahtt force-pushed the remove-glob-resolution branch from 6a0083f to 185030d Compare March 1, 2024 18:12
Gudahtt added 2 commits March 1, 2024 16:48
@Gudahtt
chore: Remove glob resolution
d2df106 
This `glob` resolution was added in #5142 to address a security
advisory. It is no longer needed, that advisory is not present after
removing the resolution.

This resolution was unsafe because it was forcing the use of
incompatible versions of the package.
@Gudahtt
Run yarn deduplicate
1a69d75
@Gudahtt Gudahtt force-pushed the remove-glob-resolution branch from 185030d to 1a69d75 Compare March 1, 2024 20:18
@sonarqubecloud

sonarqubecloud Bot commented Mar 1, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions

github-actions Bot commented Mar 1, 2024 •
edited by Gudahtt
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a69d75
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/000cc7fa-4963-498f-b29e-4d249f6d52f8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2024
@socket-security

socket-security Bot commented Mar 1, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/jackspeak@2.3.6 environment +8 506 kB isaacs

View full report↗︎

Cal-L
Cal-L approved these changes Mar 1, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 672668b into main Mar 4, 2024
@Gudahtt Gudahtt deleted the remove-glob-resolution branch March 4, 2024 13:21
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 4, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gudahtt @codecov-commenter @Cal-L @gauthierpetetin @metamaskbot @tommasini