Description

Update the TransactionController to pad the data property to an even length to ensure the client UIs receive a consistent data value.

Normalize transaction parameters before validating with the PPOM to ensure the data can be parsed correctly, and all parameters are in a consistent format.

See the core branch diff for a clearer view of the patch changes.

Related issues

Fixes: #2152 #2153

Manual testing steps

1. Update test dApp locally to remove leading zero in malicious approval data.
2. Verify associated button still displays approval confirmation.
3. Verify associated button still displays deceptive request warning.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.