Skip to content

feat: state logs in the exported file with app version and build number#8768

Merged
tommasini merged 6 commits into
mainfrom
feat/changelogs-with-app-version
Mar 4, 2024
Merged

feat: state logs in the exported file with app version and build number#8768
tommasini merged 6 commits into
mainfrom
feat/changelogs-with-app-version

Conversation

@tommasini

@tommasini tommasini commented Feb 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adding the app versions and build number to the state logs txt file

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

IOS sim: https://recordit.co/mvaITSTtQC

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added the team-mobile-platform Mobile Platform team label Feb 28, 2024
@github-actions

github-actions Bot commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 29, 2024
@tommasini tommasini marked this pull request as ready for review February 29, 2024 15:48
@tommasini tommasini requested a review from a team as a code owner February 29, 2024 15:48
@github-actions

github-actions Bot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 25ca368
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5df82883-9f30-4b7c-beb4-8cac6a8c157d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini changed the title feat: state logs with app version and build number feat: state logs in the exported file with app version and build number Feb 29, 2024
NicolasMassart
NicolasMassart reviewed Mar 1, 2024
View reviewed changes
Comment thread app/util/logs/index.test.ts
Comment thread app/util/logs/index.test.ts
NicolasMassart
NicolasMassart reviewed Mar 1, 2024
View reviewed changes
Comment thread app/util/logs/index.test.ts Outdated
NicolasMassart
NicolasMassart previously approved these changes Mar 1, 2024
View reviewed changes

@NicolasMassart NicolasMassart left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
just a nit about the test name (do not use "should",see guidelines) but if you want to keep it like this as the other test is also using this naming, it's probably fine.

tommasini and others added 2 commits March 1, 2024 20:19
@tommasini @NicolasMassart
Update app/util/logs/index.test.ts
1a387da 
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
@tommasini
Merge branch 'main' into feat/changelogs-with-app-version
b8cec18
NicolasMassart
NicolasMassart approved these changes Mar 4, 2024
View reviewed changes

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

@github-actions

github-actions Bot commented Mar 4, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d7fd8bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/518bc96b-25f7-4f1c-a50c-903de630e460

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini merged commit 8222224 into main Mar 4, 2024
@tommasini tommasini deleted the feat/changelogs-with-app-version branch March 4, 2024 17:04
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 4, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommasini @NicolasMassart @metamaskbot