Skip to content

feat: new trackErrorAsAnalytics for segment#8673

Merged
tommasini merged 1 commit into
mainfrom
feat/batch_1129_segment_12
Feb 22, 2024
Merged

feat: new trackErrorAsAnalytics for segment#8673
tommasini merged 1 commit into
mainfrom
feat/batch_1129_segment_12

Conversation

@tommasini

@tommasini tommasini commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Description

This PR create the new trackErrorAsAnalytics for segment migration

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform Mobile Platform team labels Feb 22, 2024
@tommasini tommasini requested a review from a team as a code owner February 22, 2024 15:01
@github-actions

github-actions Bot commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

NicolasMassart
NicolasMassart approved these changes Feb 22, 2024
View reviewed changes

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov-commenter

codecov-commenter commented Feb 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed7041a) 41.43% compared to head (07502f8) 41.48%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8673      +/-   ##
==========================================
+ Coverage   41.43%   41.48%   +0.05%     
==========================================
  Files        1254     1256       +2     
  Lines       30570    30581      +11     
  Branches     3001     3002       +1     
==========================================
+ Hits        12667    12687      +20     
+ Misses      17150    17141       -9     
  Partials      753      753

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 22, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini merged commit e572035 into main Feb 22, 2024
@tommasini tommasini deleted the feat/batch_1129_segment_12 branch February 22, 2024 15:39
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 22, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2024
@metamaskbot metamaskbot added release-7.18.0 Issue or pull request that will be included in release 7.18.0 in-progress labels Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

No one assigned

Labels

in-progress release-7.18.0 Issue or pull request that will be included in release 7.18.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @codecov-commenter @NicolasMassart @metamaskbot