Skip to content

fix: update podfile and project.pbxproj#8663

Merged
owencraston merged 1 commit into
mainfrom
update-pods
Feb 21, 2024
Merged

fix: update podfile and project.pbxproj#8663
owencraston merged 1 commit into
mainfrom
update-pods

Conversation

@owencraston

@owencraston owencraston commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

Description

Related issues

this change is not tracked by an issue since it is so small and benign.
Fixes:

Manual testing steps

  1. checkout this branch
  2. run yarn setup
  3. there should be git changes
  4. run the app using xcode or yarn start:ios
  5. the app should run without issues

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 13 Pro - 2024-02-21 at 14 46 15

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@owencraston owencraston requested a review from a team as a code owner February 21, 2024 22:46
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston added the team-mobile-platform Mobile Platform team label Feb 21, 2024

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@owencraston owencraston merged commit d533f4b into main Feb 21, 2024
@owencraston owencraston deleted the update-pods branch February 21, 2024 22:57
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants