Skip to content

fix: translate scam title modal#8650

Merged
salimtb merged 1 commit into
mainfrom
translate-scam-title-modal
Feb 21, 2024
Merged

fix: translate scam title modal#8650
salimtb merged 1 commit into
mainfrom
translate-scam-title-modal

Conversation

@salimtb

@salimtb salimtb commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

Description

Translation PR

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added area-translation For Blendin translation. team-mobile-ux Mobile UX team labels Feb 21, 2024
@salimtb salimtb requested a review from a team as a code owner February 21, 2024 10:06
@github-actions

github-actions Bot commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

sonarqubecloud Bot commented Feb 21, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Feb 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f42c2c2) 41.43% compared to head (ceaf6b1) 41.43%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8650   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files        1254     1254           
  Lines       30565    30565           
  Branches     3001     3001           
=======================================
  Hits        12666    12666           
  Misses      17146    17146           
  Partials      753      753

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2024
@salimtb salimtb merged commit 6b9592c into main Feb 21, 2024
@salimtb salimtb deleted the translate-scam-title-modal branch February 21, 2024 12:56
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-translation For Blendin translation. release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-ux Mobile UX team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@salimtb @codecov-commenter @blackdevelopa @gauthierpetetin @metamaskbot