Skip to content

test: Create detox setup script#8646

Merged
cortisiko merged 11 commits into
mainfrom
detox/create-detox-setup-script
Feb 21, 2024
Merged

test: Create detox setup script#8646
cortisiko merged 11 commits into
mainfrom
detox/create-detox-setup-script

Conversation

@cortisiko

@cortisiko cortisiko commented Feb 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

The purpose of this PR is to reduce the cognitive load on devs when setting up detox e2e tests.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Regression pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d987fd8b-065b-4b22-b3cd-f13d14df7850

Smoke pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d987fd8b-065b-4b22-b3cd-f13d14df7850

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this Feb 21, 2024
@codecov-commenter

codecov-commenter commented Feb 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8cc0101). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8646   +/-   ##
=======================================
  Coverage        ?   41.43%           
=======================================
  Files           ?     1254           
  Lines           ?    30565           
  Branches        ?     3001           
=======================================
  Hits            ?    12666           
  Misses          ?    17146           
  Partials        ?      753

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team labels Feb 21, 2024
@cortisiko cortisiko marked this pull request as ready for review February 21, 2024 19:08
@cortisiko cortisiko requested a review from a team as a code owner February 21, 2024 19:08
cortisiko
cortisiko commented Feb 21, 2024
View reviewed changes
Comment thread bitrise.yml
Comment thread docs/readme/testing.md
Comment thread package.json
Cal-L
Cal-L approved these changes Feb 21, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Feb 21, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2024
@cortisiko cortisiko merged commit e26750a into main Feb 21, 2024
@cortisiko cortisiko deleted the detox/create-detox-setup-script branch February 21, 2024 22:20
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@cortisiko cortisiko

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cortisiko @codecov-commenter @Cal-L @gauthierpetetin @metamaskbot