test: Refactor settings page object#8644
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8644 +/- ##
=======================================
Coverage 41.43% 41.43%
=======================================
Files 1254 1254
Lines 30565 30565
Branches 3001 3001
=======================================
Hits 12666 12666
Misses 17146 17146
Partials 753 753 ☔ View full report in Codecov by Sentry. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The purpose of this PR is to continue on with our work to refactor page objects in our e2e test code.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Smoke on main: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53f88ce9-0360-494e-84aa-4c9798983ad7
Regression on main: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27b6e69b-1f15-40be-b5a4-2d4f07f6ac82
After
Smoke: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39c38a2b-cdfd-4993-bdf3-14b3de741386
Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3903f4e-7f87-48d1-97cd-5eba0fb404d1
Pre-merge author checklist
Pre-merge reviewer checklist