Skip to content

feat: translate fake native tokens need better UX error handling#8637

Merged
salimtb merged 1 commit into
mainfrom
feat-translate-alert-tooltip
Feb 20, 2024
Merged

feat: translate fake native tokens need better UX error handling#8637
salimtb merged 1 commit into
mainfrom
feat-translate-alert-tooltip

Conversation

@salimtb

@salimtb salimtb commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

Description

Translate PR

Related issues

Fixes: #1354

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner February 20, 2024 15:45
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added area-translation For Blendin translation. team-mobile-ux Mobile UX team labels Feb 20, 2024
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 20, 2024

@MarioAslau MarioAslau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@salimtb salimtb merged commit f42c2c2 into main Feb 20, 2024
@salimtb salimtb deleted the feat-translate-alert-tooltip branch February 20, 2024 16:23
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 20, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-translation For Blendin translation. release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-ux Mobile UX team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants