You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a warning when the user switches to either Arbitrum goerli or OP goerli testnet.
This also fixes the fact that once you switch to goerli network and you close the warning. Then switch to Ethereum. Then switch back to goerli, you wont be able to see the deprecation warning again.
I've clearly explained what problem this PR is solving and how it is solved.
I've linked related issues
I've included manual testing steps
I've included screenshots/recordings if applicable
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I’ve properly set the pull request status:
In case it's not yet "ready for review", I've set it to "draft".
In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This also fixes the fact that once you switch to goerli network and you close the warning. Then switch to Ethereum. Then switch back to goerli, you wont be able to see the deprecation warning again.
I don't understand what's fixed here by reading the code it doesn't seem that this would change any logic on render level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning when the user switches to either Arbitrum goerli or OP goerli testnet.
This also fixes the fact that once you switch to goerli network and you close the warning. Then switch to Ethereum. Then switch back to goerli, you wont be able to see the deprecation warning again.
Related issues
Fixes:
Related ticket : https://consensyssoftware.atlassian.net/browse/MMASSETS-155
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-02-20.at.16.28.55.mov
After
Screen.Recording.2024-02-20.at.16.24.39.mov
Pre-merge author checklist
Pre-merge reviewer checklist