Skip to content

feat: Signature controller update to v5.3.0 and removed unnecessary patch#8608

Merged
tommasini merged 2 commits into
mainfrom
feat/1537-signature-controller-v5.3.0
Feb 19, 2024
Merged

feat: Signature controller update to v5.3.0 and removed unnecessary patch#8608
tommasini merged 2 commits into
mainfrom
feat/1537-signature-controller-v5.3.0

Conversation

@tommasini

@tommasini tommasini commented Feb 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update Signature controller to verison 5.3.0
Removed unnecessary patch

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

http://recordit.co/sjLxpGp2Of

eth_sign
https://recordit.co/f3SS2lzGLL

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Feb 16, 2024
@tommasini tommasini requested a review from a team as a code owner February 16, 2024 16:13
@github-actions

github-actions Bot commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Feb 16, 2024 •
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/message-manager@7.3.8 Transitive: environment, filesystem, network +76 12.5 MB metamaskbot
npm/@metamask/signature-controller@5.3.0 Transitive: environment, filesystem, network +90 16.5 MB metamaskbot

🚮 Removed packages: npm/@metamask/message-manager@7.3.7, npm/@metamask/signature-controller@4.0.1, npm/@metamask/utils@8.2.1

View full report↗︎

@socket-security

socket-security Bot commented Feb 16, 2024 •
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

MarioAslau
MarioAslau approved these changes Feb 16, 2024
View reviewed changes

@MarioAslau MarioAslau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sonarqubecloud

sonarqubecloud Bot commented Feb 16, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L

Cal-L commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

For the eth_sign button, you have to unfocus the input field before the button can be enabled

@github-actions

github-actions Bot commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a8a7c4d-c83b-4ba8-8fce-368832aed53b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@tommasini

tommasini commented Feb 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Eth_sign confirmed:https://recordit.co/f3SS2lzGLL
will paste on the description!

@tommasini tommasini merged commit 6788c2e into main Feb 19, 2024
@tommasini tommasini deleted the feat/1537-signature-controller-v5.3.0 branch February 19, 2024 10:26
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 19, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 19, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

No one assigned

Labels

release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @Cal-L @MarioAslau @metamaskbot