Skip to content

fix: missing converting to decimal chain id on network verification of pop…#8592

Merged
tommasini merged 1 commit into
mainfrom
fix/network-verification
Feb 15, 2024
Merged

fix: missing converting to decimal chain id on network verification of pop…#8592
tommasini merged 1 commit into
mainfrom
fix/network-verification

Conversation

@tommasini

@tommasini tommasini commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

Description

Missed conversion on chain id on network verification.

Related issues

Fixes: N/A

Manual testing steps

  1. Go to Networks list
  2. Add avalance
  3. See the warning is wrong, the chain id is known to us

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added the team-mobile-platform Mobile Platform team label Feb 15, 2024
@tommasini tommasini requested a review from a team as a code owner February 15, 2024 15:15
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tommasini tommasini merged commit 9088be3 into main Feb 15, 2024
@tommasini tommasini deleted the fix/network-verification branch February 15, 2024 15:34
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants