Skip to content

fix: revert slice engine#8587

Merged
tommasini merged 1 commit into
mainfrom
fix/revert-slice-engine
Feb 15, 2024
Merged

fix: revert slice engine#8587
tommasini merged 1 commit into
mainfrom
fix/revert-slice-engine

Conversation

@tommasini

@tommasini tommasini commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

Description

Revert of #8081

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner February 14, 2024 23:21
@github-actions

github-actions Bot commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title revert slice engine fix: revert slice engine Feb 14, 2024
@github-actions

github-actions Bot commented Feb 14, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c6b9190-c2d6-459c-a97b-b451eea74f15
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Feb 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (7956445) 41.12% compared to head (05528f7) 41.08%.

Files Patch % Lines
app/store/persistConfig.ts 12.00% 22 Missing ⚠️
app/components/UI/DrawerView/index.js 0.00% 10 Missing ⚠️
app/core/redux/slices/engine/index.ts 92.30% 0 Missing and 1 partial ⚠️
app/reducers/navigation/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8587      +/-   ##
==========================================
- Coverage   41.12%   41.08%   -0.05%     
==========================================
  Files        1246     1245       -1     
  Lines       30314    30330      +16     
  Branches     2960     2962       +2     
==========================================
- Hits        12468    12462       -6     
- Misses      17103    17125      +22     
  Partials      743      743

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 14, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
7 New issues

Measures
0 Security Hotspots
24.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Feb 14, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 8ec9970 into main Feb 15, 2024
@tommasini tommasini deleted the fix/revert-slice-engine branch February 15, 2024 00:02
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tommasini @codecov-commenter @Cal-L @metamaskbot