feat: migrate Segment core mechanism [split of 8387]#8573
Merged
NicolasMassart merged 2 commits intoFeb 14, 2024
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
f83d5e7 to
f6a6c78
Compare
- add getMetaMetricsId - add exports - fix/update tests - fix HOC types
f6a6c78 to
f3b45cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/batch_1129_segment #8573 +/- ##
========================================================
Coverage 41.23% 41.23%
========================================================
Files 1251 1251
Lines 30299 30301 +2
Branches 2926 2927 +1
========================================================
+ Hits 12494 12496 +2
Misses 17097 17097
Partials 708 708 ☔ View full report in Codecov by Sentry. |
Contributor
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca748ecb-75f4-43ea-b1df-b2d21f19f1ad |
detected by sonar
13 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
#8387 is too big for review, splitting it into contextual/domain scoped smaller PRs.
you can refer to #8387 for global view
This is the part of #8387 related to the core code of the Segment work.
update metrics system for missing features when migrating all app
Related issues
Related to MetaMask/mobile-planning/issues/1461
Manual testing steps
NA
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist