Skip to content

fix: broken WhatsNew#8560

Merged
blackdevelopa merged 3 commits into
mainfrom
8553/whatsnew_fix
Feb 14, 2024
Merged

fix: broken WhatsNew#8560
blackdevelopa merged 3 commits into
mainfrom
8553/whatsnew_fix

Conversation

@blackdevelopa

@blackdevelopa blackdevelopa commented Feb 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The WhatsNew modal isn't displayed when updating from the v7.15.0 to v7.16.0. We had previously defined the minAppVersion to v7.15.0. See comment

Related issues

Fixes: #8553

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Feb 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86d3940) 40.90% compared to head (927a721) 40.90%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8560   +/-   ##
=======================================
  Coverage   40.90%   40.90%           
=======================================
  Files        1245     1245           
  Lines       30150    30150           
  Branches     2895     2895           
=======================================
  Hits        12333    12333           
  Misses      17114    17114           
  Partials      703      703

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

digiwand
digiwand reviewed Feb 9, 2024
View reviewed changes
Comment thread app/components/UI/WhatsNewModal/whatsNewList.ts Outdated
@digiwand digiwand added the team-confirmations-secure-ux-PR PR from the confirmations team label Feb 9, 2024
seaona
seaona reviewed Feb 13, 2024
View reviewed changes
Comment thread app/components/UI/WhatsNewModal/whatsNewList.ts Outdated
@blackdevelopa blackdevelopa marked this pull request as ready for review February 13, 2024 16:09
@blackdevelopa blackdevelopa requested a review from a team as a code owner February 13, 2024 16:09
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 13, 2024
@github-actions

github-actions Bot commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4bd785d3-84de-497c-86fd-9866792a9fc8
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@blackdevelopa blackdevelopa changed the title fix broken WhatsNew fix: broken WhatsNew Feb 13, 2024
jpuri
jpuri previously approved these changes Feb 13, 2024
View reviewed changes
@blackdevelopa blackdevelopa requested a review from jpuri February 13, 2024 17:05
@sonarqubecloud

sonarqubecloud Bot commented Feb 13, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blackdevelopa blackdevelopa merged commit 5480fcc into main Feb 14, 2024
@blackdevelopa blackdevelopa deleted the 8553/whatsnew_fix branch February 14, 2024 11:29
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 14, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@seaona seaona Awaiting requested review from seaona

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: What's New not displayed on Android after upgrade (no fresh install) & Multiple issues with upcoming migrations 7.16 and 7.17

6 participants

@blackdevelopa @codecov-commenter @jpuri @digiwand @seaona @metamaskbot