Skip to content

fix: Commit script diff that appears when building iOS#8559

Merged
Cal-L merged 1 commit into
mainfrom
fix/resolve-script-diff
Feb 9, 2024
Merged

fix: Commit script diff that appears when building iOS#8559
Cal-L merged 1 commit into
mainfrom
fix/resolve-script-diff

Conversation

@Cal-L

@Cal-L Cal-L commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

Description

This resolves a diff that appears when building iOS. Fixes artifact that was missed when introducing the bundle-js-and-upload-sentry.sh script

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner February 9, 2024 06:37
@Cal-L Cal-L added the team-mobile-platform Mobile Platform team label Feb 9, 2024
@github-actions

github-actions Bot commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Feb 9, 2024
@Cal-L Cal-L changed the title Commit script diff that appears when building iOS fix: Commit script diff that appears when building iOS Feb 9, 2024
@github-actions

github-actions Bot commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5df46681-39b6-47c0-af06-9863ac774e73
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Feb 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86d3940) 40.90% compared to head (0285b98) 40.90%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8559   +/-   ##
=======================================
  Coverage   40.90%   40.90%           
=======================================
  Files        1245     1245           
  Lines       30150    30150           
  Branches     2895     2895           
=======================================
  Hits        12333    12333           
  Misses      17114    17114           
  Partials      703      703

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 9, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L Cal-L merged commit 8519adc into main Feb 9, 2024
@Cal-L Cal-L deleted the fix/resolve-script-diff branch February 9, 2024 22:34
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 9, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wachunei wachunei wachunei approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cal-L @codecov-commenter @wachunei @metamaskbot