Skip to content

feat: remove friction modal for enabling the feature from settings on iOS#8552

Merged
jpuri merged 1 commit into
mainfrom
blockaid_settings_ios_fix
Feb 8, 2024
Merged

feat: remove friction modal for enabling the feature from settings on iOS#8552
jpuri merged 1 commit into
mainfrom
blockaid_settings_ios_fix

Conversation

@jpuri

@jpuri jpuri commented Feb 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove friction modal from experimental settings while enabling blockaid on iOS.

Related issues

Fixes: MetaMask/MetaMask-planning#1996

Manual testing steps

  1. Open the app and go to experimental setting in ios device / emulator
  2. Enable blockaid setting
  3. Ensure that friction modal does not appear

Screenshots/Recordings

Screen.Recording.2024-02-08.at.2.19.43.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Feb 8, 2024
@jpuri jpuri requested a review from a team as a code owner February 8, 2024 07:26
@github-actions

github-actions Bot commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b55898ed-a730-47f4-84de-1fd95c5695ff
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Feb 8, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (34f9da1) 0.00% compared to head (9a151cc) 40.90%.

Files Patch % Lines
...ents/Views/Settings/ExperimentalSettings/index.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           main    #8552       +/-   ##
=========================================
+ Coverage      0   40.90%   +40.90%     
=========================================
  Files         0     1245     +1245     
  Lines         0    30150    +30150     
  Branches      0     2895     +2895     
=========================================
+ Hits          0    12333    +12333     
- Misses        0    17114    +17114     
- Partials      0      703      +703

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 8, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

blackdevelopa
blackdevelopa approved these changes Feb 8, 2024
View reviewed changes

@blackdevelopa blackdevelopa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, but I am unsure what friction modal we are fixing here

@jpuri

jpuri commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

@blackdevelopa : I added screen recording to description. The friction modal that appears when blockaid is enabled has been removed in IOS.

@jpuri jpuri merged commit e470f74 into main Feb 8, 2024
@jpuri jpuri deleted the blockaid_settings_ios_fix branch February 8, 2024 13:54
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 8, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 8, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@segun segun segun approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpuri @codecov-commenter @segun @blackdevelopa @metamaskbot