Skip to content

chore(ramp): add team to CODEOWNERS#8545

Merged
wachunei merged 6 commits into
mainfrom
chore/ramp-codeowners
Mar 18, 2024
Merged

chore(ramp): add team to CODEOWNERS#8545
wachunei merged 6 commits into
mainfrom
chore/ramp-codeowners

Conversation

@wachunei

@wachunei wachunei commented Feb 7, 2024

Copy link
Copy Markdown
Member

Description

This PR adds the @MetaMask/ramp team as the Ramp code domain owners in the CODEOWNERS file

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@codecov-commenter

codecov-commenter commented Feb 7, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.74%. Comparing base (4fb3968) to head (e505af4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8545   +/-   ##
=======================================
  Coverage   43.74%   43.74%           
=======================================
  Files        1273     1273           
  Lines       31103    31103           
  Branches     3161     3161           
=======================================
  Hits        13606    13606           
  Misses      16684    16684           
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei added the team-money-movement issues related to Money Movement features label Feb 7, 2024
@github-actions

github-actions Bot commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei marked this pull request as ready for review February 29, 2024 13:51
@wachunei wachunei requested a review from a team as a code owner February 29, 2024 13:51
@github-actions

github-actions Bot commented Feb 29, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 284f14e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e0d9fad-28a2-466e-a0fd-c053be8142c4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman approved these changes Mar 15, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Mar 18, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wachunei wachunei merged commit ce55a41 into main Mar 18, 2024
@wachunei wachunei deleted the chore/ramp-codeowners branch March 18, 2024 13:53
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wachunei @codecov-commenter @sethkfman @metamaskbot