Skip to content

test: use fast swipe on account sheet modal#8541

Merged
chrisleewilcox merged 1 commit into
mainfrom
test/fast-swipe-import-wallet-account
Feb 7, 2024
Merged

test: use fast swipe on account sheet modal#8541
chrisleewilcox merged 1 commit into
mainfrom
test/fast-swipe-import-wallet-account

Conversation

@chrisleewilcox

@chrisleewilcox chrisleewilcox commented Feb 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adjust to use fast swipe to fix failure running on bitrise.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Regression tests failing: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8d2704b-055c-4aeb-9777-9876f849801e

After

Regression tests passing: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f66cf8b1-0b67-4e2b-a92a-4b3f1d78d134

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox self-assigned this Feb 7, 2024
@github-actions

github-actions Bot commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

sonarqubecloud Bot commented Feb 7, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fd60d9) 40.80% compared to head (ac46864) 40.80%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8541   +/-   ##
=======================================
  Coverage   40.80%   40.80%           
=======================================
  Files        1245     1245           
  Lines       30119    30119           
  Branches     2889     2889           
=======================================
  Hits        12289    12289           
  Misses      17127    17127           
  Partials      703      703

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cortisiko
cortisiko approved these changes Feb 7, 2024
View reviewed changes

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@chrisleewilcox chrisleewilcox added the team-mobile-platform Mobile Platform team label Feb 7, 2024
@chrisleewilcox chrisleewilcox marked this pull request as ready for review February 7, 2024 03:16
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner February 7, 2024 03:16
@github-actions

github-actions Bot commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/749d778f-dfd7-4850-92b7-7e02d7db145d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox chrisleewilcox merged commit bb6d073 into main Feb 7, 2024
@chrisleewilcox chrisleewilcox deleted the test/fast-swipe-import-wallet-account branch February 7, 2024 03:19
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 7, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees

@chrisleewilcox chrisleewilcox

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisleewilcox @codecov-commenter @cortisiko @metamaskbot