Skip to content

fix: Remove height behavior on android#8532

Merged
brianacnguyen merged 1 commit into
mainfrom
fix/bottomsheet-android
Feb 6, 2024
Merged

fix: Remove height behavior on android#8532
brianacnguyen merged 1 commit into
mainfrom
fix/bottomsheet-android

Conversation

@brianacnguyen

Copy link
Copy Markdown
Contributor

Description

  • Remove height behavior on android to fix issue with keyboardingavoidingview

Related issues

Fixes: N/A

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner February 6, 2024 07:54
@brianacnguyen brianacnguyen self-assigned this Feb 6, 2024
@github-actions

github-actions Bot commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Feb 6, 2024
@sonarqubecloud

sonarqubecloud Bot commented Feb 6, 2024

Copy link
Copy Markdown

@georgewrmarshall

Copy link
Copy Markdown
Contributor

Would be good to add before and after screen recording and manual testing steps

@brianacnguyen brianacnguyen merged commit 553be2c into main Feb 6, 2024
@brianacnguyen brianacnguyen deleted the fix/bottomsheet-android branch February 6, 2024 16:02
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2024
@metamaskbot metamaskbot added release-7.17.0 Issue or pull request that will be included in release 7.17.0 release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 6, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0.

@chrisleewilcox chrisleewilcox added release-7.17.0 Issue or pull request that will be included in release 7.17.0 and removed release-7.16.0 Issue or pull request that will be included in release 7.16.0 labels Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants