Skip to content

fix: Updated backupalert snapshot from ds tokens update#8527

Merged
brianacnguyen merged 1 commit into
mainfrom
fix/backupalert-color
Feb 5, 2024
Merged

fix: Updated backupalert snapshot from ds tokens update#8527
brianacnguyen merged 1 commit into
mainfrom
fix/backupalert-color

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Description

Updated backupalert snapshot from ds tokens update. This is currently failing CI

Related issues

Fixes: N/A

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Feb 5, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 5, 2024 19:26
@github-actions

github-actions Bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen self-assigned this Feb 5, 2024

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud

sonarqubecloud Bot commented Feb 5, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 3b9df37 into main Feb 5, 2024
@brianacnguyen brianacnguyen deleted the fix/backupalert-color branch February 5, 2024 19:38
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 5, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants