feat: Feature/1300 dapp visit event#8520
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to feature/1300-dapp-visit-event
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e3785a81-ea28-4185-888e-33e108feb85a |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8520 +/- ##
==========================================
- Coverage 41.08% 41.08% -0.01%
==========================================
Files 1245 1246 +1
Lines 30330 30355 +25
Branches 2962 2962
==========================================
+ Hits 12462 12471 +9
- Misses 17125 17141 +16
Partials 743 743 ☔ View full report in Codecov by Sentry. |
MarioAslau
left a comment
There was a problem hiding this comment.
Looks good! Left a question
|


Description
This change tracks a new event named
Dapp Visitedunder the four conditions listed in the original ticketRelated issues
Fixes:
Manual testing steps
Referencing the video below:
Dapp visited event should be triggered when:
Original scenarios here - https://github.com/MetaMask/mobile-planning/issues/1300#:~:text=the%20first%20connection.-,Scenario,-Scenario%3A%20Dapp
Screenshots/Recordings
Before
After
This video show cases all of the scenarios listed in the original ticket
Screen.Recording.2024-02-08.at.10.21.39.PM.mov
On Mixpanel

Pre-merge author checklist
Pre-merge reviewer checklist