Skip to content

chore(ramp): upgrade sdk to 1.26.2#8514

Merged
wachunei merged 2 commits into
mainfrom
chore/ramp-upgrade-sdk-1.26.2
Feb 6, 2024
Merged

chore(ramp): upgrade sdk to 1.26.2#8514
wachunei merged 2 commits into
mainfrom
chore/ramp-upgrade-sdk-1.26.2

Conversation

@wachunei

@wachunei wachunei commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR upgrades @consensys/on-ramp-sdk to version 1.26.2, which updates the staging environment URLs. It does not include any mobile related changes.

Related issues

Manual testing steps

  1. Ramp flows must not be impacted.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features needs-money-movement-qa Tickets that need feature QA on the ramps flows Run Smoke E2E labels Feb 2, 2024
@socket-security

socket-security Bot commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/on-ramp-sdk@1.26.2 Transitive: environment, filesystem, network, unsafe +15 4.58 MB pmkowalski

🚮 Removed packages: npm/@consensys/on-ramp-sdk@1.25.7

View full report↗︎

@socket-security

socket-security Bot commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@consensys/on-ramp-sdk@1.26.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@github-actions

github-actions Bot commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/42199f0c-d251-4511-a1a2-2e2a928b15fa
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Feb 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a707cef) 40.66% compared to head (ecd4656) 40.66%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8514   +/-   ##
=======================================
  Coverage   40.66%   40.66%           
=======================================
  Files        1240     1240           
  Lines       30013    30013           
  Branches     2870     2870           
=======================================
  Hits        12206    12206           
  Misses      17109    17109           
  Partials      698      698

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei

wachunei commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

@SocketSecurity ignore npm/@consensys/on-ramp-sdk@1.26.2

@wachunei wachunei marked this pull request as ready for review February 2, 2024 14:21
@wachunei wachunei requested a review from a team as a code owner February 2, 2024 14:21
@github-actions

github-actions Bot commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91f3a9ea-2fa7-42c2-b61c-73f50e383c46
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@bkirb

bkirb commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@wachunei LGTM I verified the Ramps flows ✅

@wachunei wachunei added money-movement-qa-passed and removed needs-money-movement-qa Tickets that need feature QA on the ramps flows labels Feb 6, 2024
NicolasMassart
NicolasMassart approved these changes Feb 6, 2024
View reviewed changes

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 6, 2024
@sonarqubecloud

sonarqubecloud Bot commented Feb 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wachunei wachunei merged commit 47cb393 into main Feb 6, 2024
@wachunei wachunei deleted the chore/ramp-upgrade-sdk-1.26.2 branch February 6, 2024 15:12
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

No one assigned

Labels

money-movement-qa-passed release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wachunei @codecov-commenter @bkirb @NicolasMassart @metamaskbot