Skip to content

feat: confirm button color updates when transaction is malicious#8513

Merged
jpuri merged 6 commits into
mainfrom
blockaid_confirm_button_styles
Feb 5, 2024
Merged

feat: confirm button color updates when transaction is malicious#8513
jpuri merged 6 commits into
mainfrom
blockaid_confirm_button_styles

Conversation

@jpuri

@jpuri jpuri commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Description

Red / Yellow confirm button to be displayed when transaction is reported as Malicious / Warning by blockaid

Related issues

Fixes: MetaMask/MetaMask-planning#1993

Manual testing steps

  1. To to test dapp or send flow
  2. Submit a malicious transaction
  3. Check color of submit button as validation completes

Screenshots/Recordings

Screenshot 2024-02-02 at 4 31 06 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Feb 2, 2024
@jpuri jpuri requested a review from a team as a code owner February 2, 2024 11:07
@github-actions

github-actions Bot commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Confirm button color updates when transaction is malicious feat: confirm button color updates when transaction is malicious Feb 2, 2024
@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
50.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Feb 2, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (dbd1deb) 40.67% compared to head (3a3a6f4) 40.68%.
Report is 7 commits behind head on main.

Files Patch % Lines
...pp/components/UI/ApproveTransactionReview/index.js 0.00% 9 Missing ⚠️
app/components/Views/SendFlow/Confirm/index.js 66.66% 4 Missing ⚠️
app/components/UI/SignatureRequest/index.js 60.00% 2 Missing ⚠️
app/components/UI/TransactionReview/index.js 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8513      +/-   ##
==========================================
+ Coverage   40.67%   40.68%   +0.01%     
==========================================
  Files        1240     1240              
  Lines       30012    30051      +39     
  Branches     2871     2870       -1     
==========================================
+ Hits        12206    12227      +21     
- Misses      17107    17126      +19     
+ Partials      699      698       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e642ec45-fb54-4068-94b7-382659ce328b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@jpuri jpuri merged commit 6aa53ca into main Feb 5, 2024
@jpuri jpuri deleted the blockaid_confirm_button_styles branch February 5, 2024 13:14
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 5, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@segun segun segun approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpuri @codecov-commenter @segun @blackdevelopa @metamaskbot