Skip to content

fix: Fix fullscreen issue with bottomsheet#8503

Merged
brianacnguyen merged 1 commit into
mainfrom
fix/bottomsheet
Feb 1, 2024
Merged

fix: Fix fullscreen issue with bottomsheet#8503
brianacnguyen merged 1 commit into
mainfrom
fix/bottomsheet

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Description

  • BottomSheetDialog's current fullscreen behavior attaches the Dialog to the top of the screen instead of letting the height be dictated by the maxScreenHeight, which factors in the safe area inset. This PR removes the absolute top:0 position of isFullscreen behavior

Related issues

Fixes:

Manual testing steps

  1. Go to Metamask Portfolio
  2. Connect an account

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-01.at.09.07.15.mp4

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-01.at.09.07.46.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Feb 1, 2024
@brianacnguyen brianacnguyen self-assigned this Feb 1, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner February 1, 2024 17:12
@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall approved these changes Feb 1, 2024
View reviewed changes

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Feb 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a201472) 40.67% compared to head (1038501) 40.67%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8503      +/-   ##
==========================================
- Coverage   40.67%   40.67%   -0.01%     
==========================================
  Files        1240     1240              
  Lines       30006    30011       +5     
  Branches     2871     2870       -1     
==========================================
  Hits        12206    12206              
- Misses      17101    17107       +6     
+ Partials      699      698       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 1, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 0a60d7d into main Feb 1, 2024
@brianacnguyen brianacnguyen deleted the fix/bottomsheet branch February 1, 2024 17:29
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 1, 2024
@metamaskbot metamaskbot added release-7.17.0 Issue or pull request that will be included in release 7.17.0 release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 1, 2024
@metamaskbot

metamaskbot commented Feb 1, 2024

Copy link
Copy Markdown
Collaborator

Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0.

@sethkfman sethkfman added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working labels Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-design-system All issues relating to design system in Mobile type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianacnguyen @codecov-commenter @metamaskbot @georgewrmarshall @sethkfman