Skip to content

feat: change the yellow loading banner to gray color#8502

Merged
segun merged 1 commit into
mainfrom
olu/change-blockaid-loading-banner-to-gray
Feb 2, 2024
Merged

feat: change the yellow loading banner to gray color#8502
segun merged 1 commit into
mainfrom
olu/change-blockaid-loading-banner-to-gray

Conversation

@segun

@segun segun commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Description

We need to change the yellow loading blockaid banner to gray. But right now we don't have a gray color in our design systems, so pending when this is clarified with DS team (ahem @SayaGT) we don't want this to block release, so we will use the info (blue) banner for now.

Related issues

Fixes: #1997

Manual testing steps

  1. Launch MM
  2. Perform a PPOM flaggable transaction from testdapp
  3. See the yellow banner saying This request is still being simulated......
  4. Checkout this branch
  5. Repeat 2-4
  6. Now see that the same banner is blue

Screenshots/Recordings

Before

before_yellow.mov

After

afrer_blue.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Feb 1, 2024
@segun segun self-assigned this Feb 1, 2024
@segun segun requested a review from a team as a code owner February 1, 2024 16:18
@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa687fc4-128c-43bb-b7d2-83249f104b3f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sonarqubecloud

sonarqubecloud Bot commented Feb 1, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@segun segun merged commit a707cef into main Feb 2, 2024
@segun segun deleted the olu/change-blockaid-loading-banner-to-gray branch February 2, 2024 11:50
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 2, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 2, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants