Skip to content

chore: cherry-pick #8469#8499

Merged
NicolasMassart merged 2 commits into
release/7.16.0from
chore/cherry-pick-8469
Feb 1, 2024
Merged

chore: cherry-pick #8469#8499
NicolasMassart merged 2 commits into
release/7.16.0from
chore/cherry-pick-8469

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

This PR cherry-picks #8469

## **Description**

This PR addresses a deeplink navigation issue found in MetaMask Mobile
v7.10.0 and above ([LINK TO THE
BUG](#7766)). The
update introduces key improvements for handling deeplinks:

**Issue Overview:**
Previously, deeplinks failed to function correctly when the MetaMask app
was not running in the background. This was caused by premature route
navigation attempts before the app completed its loading process.

**Implemented Solutions:**

**Conditional Deeplink Queueing**:
A queue system for deeplinks has been implemented. Deeplinks that are
triggered by [branch.io](http://branch.io/) events are queued if the app
is not fully initialized. This queued processing ensures that deeplinks
are handled correctly only once the app loads completely.

**Immediate Handling When the App Loaded:**
For instances where the app is already loaded, deeplinks from
[branch.io](http://branch.io/) events are processed immediately and
normally, without queuing. This ensures direct and standard handling of
deeplinks in an active app state.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://github.com/MetaMask/metamask-mobile/assets/61094771/629803d3-0dea-4dd8-95b0-c509d248b07a


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@NicolasMassart NicolasMassart marked this pull request as ready for review February 1, 2024 09:47
@NicolasMassart NicolasMassart requested a review from a team as a code owner February 1, 2024 09:47
@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be11f281-6b5a-4f79-8251-a264441016b5
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@github-actions

github-actions Bot commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6996c3e) 40.67% compared to head (42c357e) 40.62%.
Report is 1 commits behind head on release/7.16.0.

Files Patch % Lines
app/components/Nav/App/index.js 0.00% 9 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/7.16.0    #8499      +/-   ##
==================================================
- Coverage           40.67%   40.62%   -0.05%     
==================================================
  Files                1240     1239       -1     
  Lines               30012    30001      -11     
  Branches             2871     2871              
==================================================
- Hits                12206    12188      -18     
- Misses              17107    17113       +6     
- Partials              699      700       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Feb 1, 2024

Copy link
Copy Markdown

@NicolasMassart NicolasMassart merged commit 32dd416 into release/7.16.0 Feb 1, 2024
@NicolasMassart NicolasMassart deleted the chore/cherry-pick-8469 branch February 1, 2024 12:14
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 1, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Feb 1, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.16.0 on PR, as PR was cherry-picked in branch 7.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.16.0 Issue or pull request that will be included in release 7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants