Skip to content

fix: Cleanup/miscellaneous#8488

Merged
Cal-L merged 5 commits into
mainfrom
cleanup/miscellaneous
Jan 31, 2024
Merged

fix: Cleanup/miscellaneous#8488
Cal-L merged 5 commits into
mainfrom
cleanup/miscellaneous

Conversation

@Cal-L

@Cal-L Cal-L commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

Description

This PR just cleans and updates a few files in the codebase. They're all non functional changes

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner January 31, 2024 21:13
@github-actions

github-actions Bot commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the team-mobile-platform Mobile Platform team label Jan 31, 2024
@Cal-L Cal-L closed this Jan 31, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 31, 2024
@Cal-L Cal-L reopened this Jan 31, 2024
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Jan 31, 2024
@github-actions github-actions Bot unlocked this conversation Jan 31, 2024
@github-actions

github-actions Bot commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d23313e-09fd-4f18-adfb-9d688c296ae2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98d705a) 40.67% compared to head (dad1be5) 40.67%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8488   +/-   ##
=======================================
  Coverage   40.67%   40.67%           
=======================================
  Files        1240     1240           
  Lines       30006    30006           
  Branches     2871     2871           
=======================================
  Hits        12206    12206           
  Misses      17101    17101           
  Partials      699      699

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Jan 31, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes Jan 31, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit dbd1deb into main Jan 31, 2024
@Cal-L Cal-L deleted the cleanup/miscellaneous branch January 31, 2024 23:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 31, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Cal-L @codecov-commenter @sethkfman @cortisiko @metamaskbot