Skip to content

chore: cherry pick 8373#8477

Merged
sethkfman merged 2 commits into
release/7.16.0from
chore/cherry-pick-8373
Jan 30, 2024
Merged

chore: cherry pick 8373#8477
sethkfman merged 2 commits into
release/7.16.0from
chore/cherry-pick-8373

Conversation

@sethkfman

@sethkfman sethkfman commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Description

cherry pick #8373

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner January 30, 2024 21:02
@github-actions

github-actions Bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

sonarqubecloud Bot commented Jan 30, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Jan 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.16.0@a6bae2d). Click here to learn what that means.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.16.0    #8477   +/-   ##
=================================================
  Coverage                  ?   40.62%           
=================================================
  Files                     ?     1239           
  Lines                     ?    29989           
  Branches                  ?     2870           
=================================================
  Hits                      ?    12182           
  Misses                    ?    17109           
  Partials                  ?      698

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman merged commit ee451e4 into release/7.16.0 Jan 30, 2024
@sethkfman sethkfman deleted the chore/cherry-pick-8373 branch January 30, 2024 22:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 30, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 30, 2024
@metamaskbot

metamaskbot commented Jan 30, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.16.0 on PR, as PR was cherry-picked in branch 7.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

release-7.16.0 Issue or pull request that will be included in release 7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sethkfman @codecov-commenter @metamaskbot @leotm