Skip to content

fix: Fix title color type in settings drawer#8476

Merged
brianacnguyen merged 1 commit into
mainfrom
fix/drawer-text-type
Jan 30, 2024
Merged

fix: Fix title color type in settings drawer#8476
brianacnguyen merged 1 commit into
mainfrom
fix/drawer-text-type

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Description

  • Through the replacement work PR where I updated the UI of the settings drawer, I mistakenly updated the type of the title color from PropTypes.string to TextColor, which causes a warning. This PR reverts the type back from TextColor to PropTypes.string

Related issues

Fixes: https://github.com/MetaMask/metamask-mobile/pull/8037/files#r1471909876

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Jan 30, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 30, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner January 30, 2024 21:00
@github-actions

github-actions Bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen mentioned this pull request Jan 30, 2024
Merged
13 tasks
@codecov-commenter

codecov-commenter commented Jan 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f84f18) 40.62% compared to head (fb06ce5) 40.62%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8476   +/-   ##
=======================================
  Coverage   40.62%   40.62%           
=======================================
  Files        1239     1239           
  Lines       29989    29989           
  Branches     2870     2870           
=======================================
  Hits        12182    12182           
  Misses      17109    17109           
  Partials      698      698

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Jan 30, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 306fcbc into main Jan 30, 2024
@brianacnguyen brianacnguyen deleted the fix/drawer-text-type branch January 30, 2024 21:11
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 30, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 30, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Jan 30, 2024
@sethkfman sethkfman added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead type-bug Something isn't working labels Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wachunei wachunei wachunei approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.17.0 Issue or pull request that will be included in release 7.17.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianacnguyen @codecov-commenter @wachunei @sethkfman @metamaskbot